From 13999840c56e12e708432ee560ee83fe7c9ff361 Mon Sep 17 00:00:00 2001 From: winter Date: Sun, 16 Feb 2025 22:18:57 +0000 Subject: fix a freaky bug with note deletion and home timeline --- Digitigrade/Model/HomeTimelineItem.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'Digitigrade/Model/HomeTimelineItem.php') diff --git a/Digitigrade/Model/HomeTimelineItem.php b/Digitigrade/Model/HomeTimelineItem.php index 7e2c062..249ba91 100644 --- a/Digitigrade/Model/HomeTimelineItem.php +++ b/Digitigrade/Model/HomeTimelineItem.php @@ -32,12 +32,16 @@ class HomeTimelineItem extends Model { return $hti; } - public function toTimelineItem(): TimelineItem { + public function toTimelineItem(): ?TimelineItem { $reason = null; if (isset($this->reasonKind)) { $reason = $this->reasonKind::fromJsonReference(json_decode($this->reasonData)); } $object = $this->itemKind::fromJsonReference(json_decode($this->itemData)); + if (!isset($object)) { + $this->remove(); // it's invalid anyway it shouldn't be here + return null; + } return new TimelineItem($object, $reason); } -- cgit v1.3