winter REPORTEDLY forgot to implement subscribe routes

5 files changed, 7 insertions, 5 deletions

diff --git a/Digitigrade/HttpResponseStatus/BadRequest.php b/Digitigrade/HttpResponseStatus/BadRequest.php
index e605f70..7dd4d00 100644
--- a/Digitigrade/HttpResponseStatus/BadRequest.php
+++ b/Digitigrade/HttpResponseStatus/BadRequest.php
@@ -4,7 +4,7 @@ namespace Digitigrade\HttpResponseStatus;
 use Digitigrade\HttpResponseStatus;
 
 class BadRequest extends \Exception implements HttpResponseStatus {
-    public function __construct(?string $reason) {
+    public function __construct(?string $reason = null) {
         $this->message = $reason ?? 'Request does not conform to expectations';
     }
 
diff --git a/Digitigrade/HttpResponseStatus/Forbidden.php b/Digitigrade/HttpResponseStatus/Forbidden.php
index 4c3588f..662b9b3 100644
--- a/Digitigrade/HttpResponseStatus/Forbidden.php
+++ b/Digitigrade/HttpResponseStatus/Forbidden.php
@@ -4,7 +4,7 @@ namespace Digitigrade\HttpResponseStatus;
 use Digitigrade\HttpResponseStatus;
 
 class Forbidden extends \Exception implements HttpResponseStatus {
-    public function __construct(?string $reason) {
+    public function __construct(?string $reason = null) {
         $this->message = $reason ?? 'The provided authorization is invalid for this request';
     }
 
diff --git a/Digitigrade/HttpResponseStatus/NotFound.php b/Digitigrade/HttpResponseStatus/NotFound.php
index 7da4187..1f51f88 100644
--- a/Digitigrade/HttpResponseStatus/NotFound.php
+++ b/Digitigrade/HttpResponseStatus/NotFound.php
@@ -4,7 +4,7 @@ namespace Digitigrade\HttpResponseStatus;
 use Digitigrade\HttpResponseStatus;
 
 class NotFound extends \Exception implements HttpResponseStatus {
-    public function __construct(?string $reason) {
+    public function __construct(?string $reason = null) {
         $this->message = $reason ?? 'Request was handled but no appropriate resource found';
     }
 
diff --git a/Digitigrade/HttpResponseStatus/Unauthorized.php b/Digitigrade/HttpResponseStatus/Unauthorized.php
index ab8b080..9e8163d 100644
--- a/Digitigrade/HttpResponseStatus/Unauthorized.php
+++ b/Digitigrade/HttpResponseStatus/Unauthorized.php
@@ -4,7 +4,7 @@ namespace Digitigrade\HttpResponseStatus;
 use Digitigrade\HttpResponseStatus;
 
 class Unauthorized extends \Exception implements HttpResponseStatus {
-    public function __construct(?string $reason) {
+    public function __construct(?string $reason = null) {
         $this->message = $reason ?? 'This request requires authorization';
     }
 
diff --git a/Digitigrade/Model/Instance.php b/Digitigrade/Model/Instance.php
index 2fc2f17..168a1de 100644
--- a/Digitigrade/Model/Instance.php
+++ b/Digitigrade/Model/Instance.php
@@ -143,10 +143,12 @@ class Instance extends FetchableModel {
             throw new \RuntimeException("can't (un)subscribe to $this->domain because i don't have an outbound token for it");
         }
         $context = stream_context_create(['http' => [
+            'method' => 'POST',
             'header' => 'Authorization: Bearer ' . $this->auth->outboundToken
         ]]);
         file_get_contents($isUnsubscribe ? $this->endpoints->unsubscribe : $this->endpoints->subscribe, context: $context);
-        return str_contains($http_response_header[0], '200');
+        // it ought to return 204 but i'll allow 200 for compatibility's sake
+        return str_contains($http_response_header[0], '204') || str_contains($http_response_header[0], '200');
     }
 
     /**